Better logging and tracing for stream errors#38013
Merged
lmolkova merged 8 commits intoAzure:mainfrom Jan 11, 2024
Merged
Conversation
lmolkova
requested review from
JonathanGiles,
alzimmermsft,
anuchandy,
billwert,
mssfang,
samvaity,
srnagar,
trask and
vcolin7
as code owners
lmolkova
commented
Dec 11, 2023
...zure-core/src/main/java/com/azure/core/implementation/http/policy/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
Collaborator
|
API change check API changes are not detected in this pull request. |
sdk/core/azure-core/src/main/java/com/azure/core/http/policy/HttpLoggingPolicy.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
stream-errors-better-obs
branch
from
581139f to
6a34aa2
Compare
alzimmermsft
approved these changes
Jan 5, 2024
sdk/core/azure-core/src/main/java/com/azure/core/http/policy/HttpLoggingPolicy.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 8, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/io/IOUtils.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
stream-errors-better-obs
branch
from
74a0083 to
8fd1e0f
Compare
Author
yes, but the reason for this change is to fix something we hit in the stress tests - telemetry shows that everything is fine when connection resets in the middle of the response stream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37978 and #37975
Issues came up in storage stress tests where lack of context makes it difficult or impossible to reconstruct what the Storage SDK was doing when stream reading error happens (e.g. how many bytes were actually downloaded in which try)
Description
x-ms-client-request-idandtraceparent) to stream reading helpers error logs that previously had no contextAfter: