Add Token Credential Samples with DTFx.AzureStorage v1 and v2#1118
Merged
Add Token Credential Samples with DTFx.AzureStorage v1 and v2#1118
Conversation
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
Some notes, glad this is almost out
samples/ManagedIdentitySample/DTFx.AzureStorage v1.x/ConsoleApp.csproj
Outdated
Show resolved
Hide resolved
samples/ManagedIdentitySample/DTFx.AzureStorage v2.x/ConsoleApp.csproj
Outdated
Show resolved
Hide resolved
…letask into nytian/add-mi-smaple
lilyjma
approved these changes
Jun 25, 2024
Collaborator
lilyjma
left a comment
lilyjma
left a comment
There was a problem hiding this comment.
Left a few clarifying questions.
samples/ManagedIdentitySample/DTFx.AzureStorage v2.x/Program.cs
Outdated
Show resolved
Hide resolved
davidmrdavid
approved these changes
Jun 25, 2024
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
Some minor nits - please incorporate this feedback and then merge.
samples/ManagedIdentitySample/DTFx.AzureStorage v1.x/ConsoleApp.csproj
Outdated
Show resolved
Hide resolved
samples/ManagedIdentitySample/DTFx.AzureStorage v2.x/ConsoleApp.csproj
Outdated
Show resolved
Hide resolved
bachuv
reviewed
Jun 26, 2024
samples/ManagedIdentitySample/DTFx.AzureStorage v2.x/Program.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled. Add samples about how to use identity-based connection with DTFx framework app.