Merged
Conversation
zhiying-lin
force-pushed
the
update-doc
branch
from
ce7be41 to
36dc56b
Compare
jwtty
reviewed
Feb 26, 2025
docs/tutorials/ApplicationMigration/testfiles/ro-nginx-service-export.yaml
Outdated
Show resolved
Hide resolved
docs/tutorials/BuildMultiClusterApplication/BuildMultiClusterApplication.md
Show resolved
Hide resolved
docs/tutorials/BuildMultiClusterApplication/BuildMultiClusterApplication.md
Show resolved
Hide resolved
Contributor
|
LGTM, thanks |
jwtty
approved these changes
Feb 26, 2025
Arvindthiru
reviewed
Mar 17, 2025
| metadata: | ||
| name: ro-nginx-service | ||
| name: nginx-service | ||
| namespace: multi-cluster-app |
Contributor
There was a problem hiding this comment.
Suggestion: Adding a step to create the ns multi-cluster-app
Arvindthiru
reviewed
Mar 17, 2025
| path: /metadata/annotations | ||
| value: | ||
| {"service.beta.kubernetes.io/azure-dns-label-name":"fleet-multi-cluster-app-member-1"} | ||
| {"service.beta.kubernetes.io/azure-dns-label-name":"multi-cluster-app-${MEMBER-CLUSTER-NAME}"} |
Contributor
There was a problem hiding this comment.
nit: Link to the resource override doc explaining how ${MEMBER-CLUSTER-NAME} works would be helpful
Arvindthiru
reviewed
Mar 17, 2025
| > Note: Please update the dns label name to match your specific requirements, and the "multi-cluster-app-${MEMBER-CLUSTER-NAME}" may be not available. | ||
|
|
||
|
|
||
| #### Deployment |
Contributor
There was a problem hiding this comment.
The namespace of the deployment inside the envelope-configmap still uses test-app instead of multi-cluster-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer