feat: watch for drift/diff reportings in the CRB watcher#1026
Merged
ryanzhang-oss merged 2 commits intoAzure:mainfrom Jan 30, 2025
Merged
feat: watch for drift/diff reportings in the CRB watcher#1026ryanzhang-oss merged 2 commits intoAzure:mainfrom
ryanzhang-oss merged 2 commits intoAzure:mainfrom
Conversation
| fakePlacementController.ResetQueue() | ||
| }) | ||
|
|
||
| It("Should enqueue the clusterResourcePlacement name for reconciling, when there are no more drifted placements", func() { |
Contributor
There was a problem hiding this comment.
Suggested change
| It("Should enqueue the clusterResourcePlacement name for reconciling, when there are no more drifted placements", func() { | |
| It("Should enqueue the clusterResourcePlacement name for reconciling, when there are no more diffed placements", func() { |
| fakePlacementController.ResetQueue() | ||
| }) | ||
|
|
||
| It("Should not enqueue the clusterResourcePlacement name for reconciling, when there are only order changes in the drifted placement list", func() { |
Contributor
There was a problem hiding this comment.
Suggested change
| It("Should not enqueue the clusterResourcePlacement name for reconciling, when there are only order changes in the drifted placement list", func() { | |
| It("Should not enqueue the clusterResourcePlacement name for reconciling, when there are only order changes in the diffed placement list", func() { |
ryanzhang-oss
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR enables the CRB watcher controller to detect drift/diff reporting changes.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer