feat: move the rollout controller to event driven model#1029
Merged
michaelawyu merged 12 commits intoAzure:mainfrom Feb 18, 2025
Merged
feat: move the rollout controller to event driven model#1029michaelawyu merged 12 commits intoAzure:mainfrom
michaelawyu merged 12 commits intoAzure:mainfrom
Conversation
ryanzhang-oss
force-pushed
the
fix-rollout-watch
branch
from
f5fb9bf to
a9ea18c
Compare
michaelawyu
reviewed
Feb 5, 2025
Contributor
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
Hi Ryan! I've added some comments, PTAL 🙏
ryanzhang-oss
force-pushed
the
fix-rollout-watch
branch
from
ed4ed9d to
7fba3b1
Compare
Contributor
Author
|
The bug was the workGenerator controller will mark the binding as overridden failed but rollout controller doesn't consider that binding has "FAILED". This leads to the roll out stuck because the binding can be ready thus it prevent the maxNumber to go over. There needs to be a follow up on the workGenerator/applier to differentiate (best effort) user error/not retriable error from retriable. |
ryanzhang-oss
force-pushed
the
fix-rollout-watch
branch
from
07e30c7 to
5ed16b6
Compare
michaelawyu
previously approved these changes
Feb 14, 2025
Contributor
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
LGTM ;) Has some minor comments; will add them later -> merging the PR now upon test completion to unblock progress
ryanzhang-oss
force-pushed
the
fix-rollout-watch
branch
from
990d18d to
1c6e011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer