fix: fix the namespace empty with resource override list#1054
fix: fix the namespace empty with resource override list#1054zhiying-lin merged 4 commits intoAzure:mainfrom
Conversation
ryanzhang-oss
force-pushed
the
fix-override
branch
from
0e4a6ab to
133f06d
Compare
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" | ||
| v1 "k8s.io/api/core/v1" |
There was a problem hiding this comment.
| v1 "k8s.io/api/core/v1" | |
| corev1 "k8s.io/api/core/v1" |
There was a problem hiding this comment.
I wonder why it's better to name it corev1?
There was a problem hiding this comment.
v1 is quite common as the k8 api package.
Without looking at the actual import path, we don't know what's the package. corev1 is quite commonly used in our repo now.
So it's easier to figure out it stands for "k8s.io/api/core/v1"
| Name: namespaceName, | ||
| }, | ||
| } | ||
| Expect(k8sClient.Delete(ctx, namespace)).Should(SatisfyAny(Succeed(), &utils.NotFoundMatcher{})) |
There was a problem hiding this comment.
i find the utils.NotFoundMatcher can be replaced by "WithTransform(errors.IsNotFound, BeTrue())" when working on the atm features
There was a problem hiding this comment.
good to know but I think we can keep this matcher in this repo
| "github.com/google/go-cmp/cmp" | ||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| v1 "k8s.io/api/core/v1" |
There was a problem hiding this comment.
| v1 "k8s.io/api/core/v1" | |
| corev1 "k8s.io/api/core/v1" |
|
need to add e2e tests for RO, with same name but different namespace name, (it can be in a separate PR) |
2 participants
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer