feat: Remove immature internalMemberCluster CR update#110
Merged
minhng22 merged 1 commit intoAzure:mainfrom Jun 20, 2022
Merged
feat: Remove immature internalMemberCluster CR update#110minhng22 merged 1 commit intoAzure:mainfrom
minhng22 merged 1 commit intoAzure:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 65.53% 66.82% +1.29%
==========================================
Files 3 3
Lines 618 615 -3
==========================================
+ Hits 405 411 +6
+ Misses 205 197 -8
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
Member
Author
|
There is no needs to add testing for this change now as it would be covered in #98 |
helayoty
approved these changes
Jun 20, 2022
helayoty
reviewed
Jun 20, 2022
Contributor
There was a problem hiding this comment.
Can you make sure that the UT is updated as well to reflect this change?
Member
Author
There was a problem hiding this comment.
Yes I tested the suite(s), not just the integration tests. This change isn't covered in UT and is covered in the controller tests (ginkgo).
zhiying-lin
added a commit
to zhiying-lin/fleet
that referenced
this pull request
Jun 25, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested both imc and membership suites
Special notes for your reviewer