Closed
Conversation
helayoty
reviewed
Jun 21, 2022
Contributor
There was a problem hiding this comment.
We need to use fleetv1alpha1.ConditionTypeMembershipLeave instead
Member
Author
There was a problem hiding this comment.
There is no fleetv1alpha1.ConditionTypeMembershipLeave.
Member
Author
There was a problem hiding this comment.
We use 1 condition type and update the status to reflect the state
fleet/apis/v1alpha1/membership_types.go
Line 60 in 6ec3420
Member
Author
|
There was miscommunication changes in this PR aren't what requested. Resolving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
Clean/ consistent up var name
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Ran and passed all test suites and
Special notes for your reviewer