Skip to content

fix: add permission to delete namespaces and update examples#116

Merged
helayoty merged 1 commit intoAzure:mainfrom
helayoty:hub-chart-role
Jun 28, 2022
Merged

fix: add permission to delete namespaces and update examples#116
helayoty merged 1 commit intoAzure:mainfrom
helayoty:hub-chart-role

Conversation

@helayoty
Copy link
Contributor

Description of your changes

  • Add the delete verb to the hub-agent helm chart
  • Update the examples

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Copy link
Member

@minhng22 minhng22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #124 this LGTM

Copy link
Contributor

@Arvindthiru Arvindthiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@helayoty helayoty merged commit eace18e into Azure:main Jun 28, 2022
@helayoty helayoty deleted the hub-chart-role branch June 28, 2022 19:28
zhiying-lin added a commit to zhiying-lin/fleet that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants