feat: add headers for tenantID and clientRequestID#1228
Merged
jwtty merged 1 commit intoAzure:mainfrom Nov 20, 2025
Merged
Conversation
zhiying-lin
reviewed
Nov 19, 2025
zhiying-lin
approved these changes
Nov 20, 2025
| serverAddress string, | ||
| httpClient *http.Client, | ||
| ) (*AttributeBasedVMSizeRecommenderClient, error) { | ||
| tenantID := os.Getenv(tenantIDEnvVarName) |
Contributor
There was a problem hiding this comment.
just curious, who set this env?
Contributor
Author
There was a problem hiding this comment.
The env var will be set in the fleet-hub-agent chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Set headers for
tenantIDandclientRequestIDin attributeBasedVMSizeRecommender clientFixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested in standalone with a test client: 88caa9
fleet-hub-agent deployment is updated with environment vars:
VMSize recommendation is successfully generated:
clientRequestID is properly passed to compute-svc too:
Special notes for your reviewer