feat: Enabled webhook in upstream & prod via config. by Ealianis · Pull Request #330 · Azure/fleet

Ealianis · 2022-10-10T22:38:31Z

Description of your changes

Added a new option to specify if the webhook will use a Service Ref or URL within its webhook client configuration.
Added test to ensure CREATE / UPDATE / DELETE works within whitelisted namespaces.
Added test to ensure CREATE is denied within non-whitelisted namespaces.
Added tests for valid / invalid CRPs

Fixes: #283

I have:

Run make reviewable to ensure this PR is ready for review.
Run E2E tests locally with 100% success
Verified webhook works in production with ConnectionType = URL.

cmd/hubagent/options/options.go

cmd/hubagent/options/webhookconnectiontype.go

cmd/hubagent/main.go

pkg/webhook/webhook.go

…age.

…ed maker file for local testing.

Makefile

cmd/hubagent/options/webhookconnectiontype.go

pkg/webhook/webhook.go

charts/hub-agent/templates/webhookservice.yaml

cmd/hubagent/main.go

cmd/hubagent/options/webhookconnectiontype.go

test/e2e/webhook_test.go

cmd/hubagent/main.go

pkg/webhook/webhook.go

…o feat-webhook-connectiontype

pkg/webhook/webhook.go

test/e2e/webhook_test.go

…yle improvements.

pkg/webhook/webhook.go

test/e2e/webhook_test.go

…zure#330) fix scheduler for future implementation Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

Added new option for webhook client connection type.

89fbb8a

ryanzhang-oss reviewed Oct 10, 2022

View reviewed changes

cmd/hubagent/options/options.go Outdated Show resolved Hide resolved

ryanzhang-oss reviewed Oct 10, 2022

View reviewed changes

cmd/hubagent/options/webhookconnectiontype.go Outdated Show resolved Hide resolved

cmd/hubagent/main.go Outdated Show resolved Hide resolved

cmd/hubagent/main.go Outdated Show resolved Hide resolved

pkg/webhook/webhook.go Outdated Show resolved Hide resolved

Sean Hobbs added 7 commits October 10, 2022 17:23

Refactored validation of webhook client connection type string and us…

a0c80b4

…age.

Set default value to be AKS Production friendly.

6f8a0b8

Exposed webhook path constants.

c53fa3f

Added func to create client configs dynamically.

b313c8b

WIP

04b7cdd

Fixed lookup. Fixed interface arguments.

c7736ba

Removed dead code comment. Cleaned up cert details.

463afba

Ealianis changed the title ~~feat: Added new option for webhook client connection type.~~ feat: Enabled webhook in upstream & prod via config. Oct 11, 2022

Sean Hobbs added 3 commits October 11, 2022 11:08

Updated deployment values to match AKS production expectations. Updat…

3de6f36

…ed maker file for local testing.

Updated deployment values to match AKS production expectations. Updat…

7ee54c7

…ed maker file for local testing.

Temp - Removed WIP webhook e2e test.

5a049d3

ryanzhang-oss reviewed Oct 11, 2022

View reviewed changes

Sean Hobbs and others added 5 commits October 11, 2022 15:01

Set webhook to enabled by default

8064042

Fixed variable names, and usage

1b25682

Merge branch 'Azure:main' into feat-webhook-connectiontype

6fd521b

WIP - E2E Test for pod validation webhook.

fb4db6d

linted code

411f305

ryanzhang-oss reviewed Oct 14, 2022

View reviewed changes

charts/hub-agent/templates/webhookservice.yaml Show resolved Hide resolved

Sean Hobbs and others added 6 commits October 14, 2022 15:42

Updated webhook test to be more thorough.

b429d2e

Merge branch 'Azure:main' into feat-webhook-connectiontype

c6a8202

Removed verification of downstream implementation.

73ff928

Added error type & message check. Removed false positive checks.

2099392

Merge branch 'Azure:main' into feat-webhook-connectiontype

e50b251

Updated It block text.

51aa998

Ealianis self-assigned this Oct 18, 2022

Ealianis marked this pull request as ready for review October 18, 2022 23:18

Merge branch 'Azure:main' into feat-webhook-connectiontype

43e9555

Ealianis and others added 4 commits October 25, 2022 15:53

Merge branch 'Azure:main' into feat-webhook-connectiontype

134f0de

Reverted change to webhook events.

811074c

Updated webhook tests for CRP.

65f2f95

Removed constants that existed in test utils.

13f5d49

zhiying-lin reviewed Oct 27, 2022

View reviewed changes

Sean Hobbs and others added 5 commits October 27, 2022 10:37

Small fixes.

0254bb3

Small fixes.

50ab130

Merge branch 'Azure:main' into feat-webhook-connectiontype

6e650ba

Small fixes.

0277a4f

PR comment fixes.

255154d

zhiying-lin reviewed Oct 28, 2022

View reviewed changes

cmd/hubagent/main.go Outdated Show resolved Hide resolved

pkg/webhook/webhook.go Outdated Show resolved Hide resolved

Sean Hobbs and others added 2 commits October 28, 2022 11:14

Refactor to of webhook.go.

6c52a11

Merge branch 'Azure:main' into feat-webhook-connectiontype

4d7521d

Ealianis mentioned this pull request Oct 28, 2022

feat: webhook disable ReplicaSet #335

Closed

1 task

Sean Hobbs added 2 commits October 28, 2022 13:25

Typo.

9af6ecf

Merge remote-tracking branch 'origin/feat-webhook-connectiontype' int…

d8ab0bf

…o feat-webhook-connectiontype

ryanzhang-oss reviewed Oct 28, 2022

View reviewed changes

Sean Hobbs added 2 commits October 28, 2022 14:43

Reduced webhook operation calls. Removed duplicate code and missed st…

f1339ca

…yle improvements.

Restructured test cases. Added update to each create denial test.

8bdaa22

ryanzhang-oss approved these changes Oct 29, 2022

View reviewed changes

zhiying-lin reviewed Oct 31, 2022

View reviewed changes

Ealianis merged commit ce5f201 into Azure:main Oct 31, 2022

Ealianis deleted the feat-webhook-connectiontype branch October 31, 2022 20:36

britaniar added a commit to britaniar/fleet that referenced this pull request Nov 18, 2025

fix: update scheduler to support customized cluster affinity plugin (A…

309526b

…zure#330) fix scheduler for future implementation Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

britaniar added a commit to britaniar/fleet that referenced this pull request Nov 18, 2025

fix: update scheduler to support customized cluster affinity plugin (A…

09ccb48

…zure#330) fix scheduler for future implementation Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

britaniar added a commit to britaniar/fleet that referenced this pull request Nov 19, 2025

fix: update scheduler to support customized cluster affinity plugin (A…

2c4833f

…zure#330) fix scheduler for future implementation Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

michaelawyu mentioned this pull request Nov 19, 2025

chore: backport changes (11/19/2025) #1230

Merged

1 task

britaniar added a commit to britaniar/fleet that referenced this pull request Nov 19, 2025

fix: update scheduler to support customized cluster affinity plugin (A…

830e09e

…zure#330) fix scheduler for future implementation Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

britaniar added a commit to britaniar/fleet that referenced this pull request Nov 19, 2025

fix: update scheduler to support customized cluster affinity plugin (A…

047cad5

…zure#330) fix scheduler for future implementation Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

Conversation

Ealianis commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of your changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ealianis commented Oct 10, 2022 •

edited

Loading