feat: enforce revisionHistoryLimit for resource snapshots#426
Merged
zhiying-lin merged 5 commits intoAzure:mainfrom Jul 14, 2023
Merged
feat: enforce revisionHistoryLimit for resource snapshots#426zhiying-lin merged 5 commits intoAzure:mainfrom
zhiying-lin merged 5 commits intoAzure:mainfrom
Conversation
zhiying-lin
force-pushed
the
resource-cleanup
branch
from
0b51676 to
bebcf19
Compare
zhiying-lin
force-pushed
the
resource-cleanup
branch
from
bebcf19 to
1519d34
Compare
michaelawyu
reviewed
Jul 12, 2023
michaelawyu
reviewed
Jul 12, 2023
michaelawyu
reviewed
Jul 12, 2023
michaelawyu
reviewed
Jul 12, 2023
michaelawyu
reviewed
Jul 12, 2023
Contributor
|
Can we delete a snapshot that still has bindings pointing to it? |
zhiying-lin
force-pushed
the
resource-cleanup
branch
from
3d9395c to
9f9902f
Compare
zhiying-lin
force-pushed
the
resource-cleanup
branch
from
9f9902f to
4158c7d
Compare
michaelawyu
reviewed
Jul 14, 2023
michaelawyu
reviewed
Jul 14, 2023
michaelawyu
reviewed
Jul 14, 2023
Contributor
|
Other than the comments, everything LGTM ;) |
weng271190436
pushed a commit
to weng271190436/fleet
that referenced
this pull request
Feb 5, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
UT
Special notes for your reviewer