feat: init v1beta1 work controller when enabling v1beta1 api#515
Merged
zhiying-lin merged 2 commits intoAzure:mainfrom Sep 8, 2023
Merged
feat: init v1beta1 work controller when enabling v1beta1 api#515zhiying-lin merged 2 commits intoAzure:mainfrom
zhiying-lin merged 2 commits intoAzure:mainfrom
Conversation
zhiying-lin
changed the title
zhiying-lin
changed the title
zhiying-lin
force-pushed
the
work-controller-caller
branch
from
ae96aa5 to
865ee1b
Compare
zhiying-lin
changed the title
zhiying-lin
force-pushed
the
work-controller-caller
branch
from
865ee1b to
27730bb
Compare
michaelawyu
reviewed
Sep 7, 2023
michaelawyu
previously approved these changes
Sep 7, 2023
Contributor
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
LGTM, except one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer