feat: v1beta1 CRP validation for PickAll Placement policy#552
Merged
ryanzhang-oss merged 6 commits intoAzure:mainfrom Oct 11, 2023
Merged
feat: v1beta1 CRP validation for PickAll Placement policy#552ryanzhang-oss merged 6 commits intoAzure:mainfrom
ryanzhang-oss merged 6 commits intoAzure:mainfrom
Conversation
Arvindthiru
changed the title
Arvindthiru
force-pushed
the
v1beta1CRP2
branch
2 times, most recently
from
f368813 to
64b0b1f
Compare
Arvindthiru
changed the title
| }, testutils.PollTimeout, testutils.PollInterval).Should(Succeed()) | ||
| }) | ||
|
|
||
| It("should deny update on CRP with invalid placement policy for PickAll", func() { |
Contributor
There was a problem hiding this comment.
Strictly speaking we don't really need this e2e. Doesn't hurt to have one but why not pick something specific error related to the pickAll?
Contributor
Author
There was a problem hiding this comment.
Agreed, we don't actually need the E2Es but I wanted to at least cover some important cases in E2Es that are already covered by UTs just to provide solid proof
I am testing a bad label selector within cluster affinity which is within RequiredDuringSchedulingIgnoredDuringExecution which is specific to PickAll, I also added topology constraints which is not allowed for PickAll
Arvindthiru
force-pushed
the
v1beta1CRP2
branch
from
e2e2af3 to
83b6440
Compare
| } | ||
| } | ||
|
|
||
| func Test_ValidateClusterResourcePlacement_PickAllPlacementPolicy(t *testing.T) { |
Contributor
There was a problem hiding this comment.
is the invalid case of PreferreAffinity covered?
ryanzhang-oss
approved these changes
Oct 11, 2023
britaniar
added a commit
to britaniar/fleet
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer