feat: Add join e2e tests#81
Merged
ryanzhang-oss merged 1 commit intoAzure:mainfrom Jun 24, 2022
helayoty:e2e-join
Merged
Conversation
helayoty
commented
Jun 22, 2022
| env: | ||
| KUBECONFIG: /home/runner/.kube/config | ||
| KUBECONFIG: '/home/runner/.kube/config' | ||
| HUB_SERVER_URL: 'https://172.19.0.2:6443' No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This shouldn't be hard coded. I couldn't find a way to pass this variable to the e2e test here
helayoty
commented
Jun 22, 2022
| apiVersion: kind.x-k8s.io/v1alpha4 | ||
| nodes: | ||
| - role: control-plane | ||
| - role: worker |
Contributor
Author
There was a problem hiding this comment.
No need for multiple nodes in the e2e tests
helayoty
commented
Jun 22, 2022
helayoty
commented
Jun 22, 2022
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Install helm |
Contributor
Author
There was a problem hiding this comment.
I had to remove all the setup to be makefile targets. It failed to update the token/URL in the previous setup
helayoty
requested review from
Arvindthiru,
minhng22 and
ryanzhang-oss
and removed request for
Arvindthiru
minhng22
reviewed
Jun 22, 2022
Member
minhng22
left a comment
minhng22
left a comment
There was a problem hiding this comment.
Some minors comments. I would do more review on this.
| env: | ||
| KUBECONFIG: /home/runner/.kube/config | ||
| KUBECONFIG: '/home/runner/.kube/config' | ||
| HUB_SERVER_URL: 'https://172.19.0.2:6443' No newline at end of file |
ryanzhang-oss
approved these changes
Jun 24, 2022
Contributor
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
we can adjust this later
britaniar
pushed a commit
to britaniar/fleet
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR has:
rbacpermissions for hub/member chartshub-agentchart so we can pull it out intomemberclusterI have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer