feat: Membership controller test join flow.#83
Merged
minhng22 merged 3 commits intoAzure:mainfrom Jun 13, 2022
Merged
Conversation
minhng22
force-pushed
the
membership-contr-test
branch
4 times, most recently
from
d2bc46e to
c48ef45
Compare
Arvindthiru
reviewed
Jun 13, 2022
pkg/controllers/membership/membership_controller_integration_test.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
Jun 13, 2022
pkg/controllers/membership/membership_controller_integration_test.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
Jun 13, 2022
pkg/controllers/membership/membership_controller_integration_test.go
Outdated
Show resolved
Hide resolved
Contributor
|
Fix Lint issue |
minhng22
force-pushed
the
membership-contr-test
branch
from
c48ef45 to
83369b9
Compare
Contributor
|
Is this the only PR for the Join workflow cause these lines are not covered by the test in this PR https://github.com/Azure/fleet/blob/main/pkg/controllers/membership/membership_controller.go#L86-L88 |
Member
Author
|
No there will be multiple PRs. @Arvindthiru |
Arvindthiru
approved these changes
Jun 13, 2022
zhiying-lin
pushed a commit
to zhiying-lin/fleet
that referenced
this pull request
Jul 2, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding test for the membership controller test join flow.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer