feat: restrict the membercluster name length to 63#946
Merged
jamyct merged 41 commits intoAzure:mainfrom Nov 20, 2024
Merged
Conversation
jamyct
changed the title
zhiying-lin
reviewed
Nov 8, 2024
config/crd/bases/cluster.kubernetes-fleet.io_memberclusters.yaml
Outdated
Show resolved
Hide resolved
britaniar
reviewed
Nov 8, 2024
config/crd/bases/cluster.kubernetes-fleet.io_memberclusters.yaml
Outdated
Show resolved
Hide resolved
zhiying-lin
reviewed
Nov 8, 2024
zhiying-lin
reviewed
Nov 8, 2024
zhiying-lin
reviewed
Nov 13, 2024
Contributor
Author
|
Manual test for name length restriction:
Manual test for regex (as per RFC 1123 Label Names):
|
zhiying-lin
reviewed
Nov 18, 2024
zhiying-lin
reviewed
Nov 19, 2024
…ustername-length merge with latest main branch
zhiying-lin
reviewed
Nov 20, 2024
zhiying-lin
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
restrict the membercluster name length to 63 and ensure it follows RFC 1035 Label Names
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer