feat: support placement field in the override#988
Merged
zhiying-lin merged 2 commits intoAzure:mainfrom Dec 13, 2024
Merged
Conversation
jwtty
reviewed
Dec 12, 2024
Contributor
jwtty
left a comment
jwtty
left a comment
There was a problem hiding this comment.
Yeah, I think the new feature works with the stagedUpdateRun. Thanks!
Contributor
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
It would be good to have an e2e to cover this too
zhiying-lin
force-pushed
the
override-with-placement
branch
from
8d6bb98 to
dd87273
Compare
Contributor
Author
i'm going to add it in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Filter out when the override is not configured for the target placement when rolling out the resources
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
added unit test
Special notes for your reviewer
Watching the override snapshot resources in the rollout controller will be in a separate PR