Update Docker push commands and add checks for App properties#149
Merged
Phydeauxman merged 3 commits intomainfrom Apr 13, 2021
Merged
Update Docker push commands and add checks for App properties#149Phydeauxman merged 3 commits intomainfrom
Phydeauxman merged 3 commits intomainfrom
Conversation
- Added code to wait for App properties
glennmusa
approved these changes
Apr 13, 2021
Contributor
glennmusa
left a comment
glennmusa
left a comment
There was a problem hiding this comment.
We still have work to do to pass along the Key Vault DNS suffix and the ARM metadatahost endpoint URL from the results of az cloud show but let's do that in another change. LGTM 👍
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the commands used to push Docker image to use dynamic endpoints.
Added login to wait for the App creation process to propagate all properties before proceeding
Issue reference
The issue this PR will close: #144
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)