Disable SNAT regardless of the destination IP address (Firewall) since forced tunneling is turned on#194
Merged
Disable SNAT regardless of the destination IP address (Firewall) since forced tunneling is turned on#194
Conversation
Contributor
Author
|
|
Contributor
|
Looks like a good change to me 👍. Can we update the PR title to something understandable two months from now? Since we squash and merge into main in this repository, the title of your PR is what makes it into the git log and it helps to have a succinct, yet descriptive commit message if we need to hunt for a bug or unwind changes. |
glennmusa
reviewed
May 5, 2021
jjansen23
changed the title
jjansen23
changed the title
glennmusa
approved these changes
May 6, 2021
Contributor
glennmusa
left a comment
glennmusa
left a comment
There was a problem hiding this comment.
Awesome! Thanks @jjansen23 for the contribution!
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
…e forced tunneling is turned on (Azure#194) * testing snat * corrected string type * corrected list type * changed variable for private_ip_ranges to be more readbale to user Co-authored-by: jjansen23 <jerome@DESKTOP-IMETN7E.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure the firewall to never SNAT regardless of the destination IP address, preventing Azure Firewall from routing traffic directly to the internet
Issue reference
The issue this PR will close: #118
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)