Add unattended terraform execution, centralize Service Principal check, exit on any errors#63
Merged
brooke-hamilton merged 9 commits intomainfrom Mar 5, 2021
Merged
Conversation
brooke-hamilton
approved these changes
Mar 5, 2021
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
…k, exit on any errors (Azure#63) * add apply_tf and destroy_tf * reverse order on apply * use vars * add helpers and refactor terraform commands * exit if any subshell should error * exit on errors * add readme, shellcheck files * clarify config generation * Update README.md Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See build/README.md on how to execute/demo this.
As of this writing, round-trip apply/destroy for everything under src/core takes ~35 minutes (most of it on Azure Firewall apply).
Changes:
Adds apply_tf and destroy_tf
These two scripts automate what a human currently does to deploy the terraform configurations at src/core in the repository.
Adds scripts/config/get_sp_identity.sh
This script validates that Service Principal used by Terraform is available in the MLZ Configuration Resources Key Vault before attempting to use it to invoke terraform and deploy resources.
Prepends all shell scripts in the solution with
set -eIssue reference
The issue this PR will close: #16, #62
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)