Regression tests: Audience#2838

Merged

iNinja merged 15 commits intodevfrom

iinglese/regression-tests-audience

Oct 1, 2024

Contributor

iNinja commented Sep 23, 2024

Regression tests: Audience

Extracted regression tests related to audience to a separate file.
Added extra scenarios for audience related validations.
Fixed audience validation unit tests and renamed variables to improve clarity.

Note: Upcoming PRs will continue to extract the different aspects of regression tests into separate files.

Part of #2711

iNinja added 2 commits

September 23, 2024 14:47


          Fixed audience validator unit tests. Renamed variables to improve cla…

…rity.


          Extracted regression tests related to audience to a separate file. Ad…

76e6b9b

…ded remaining regression tests for audience scenarios.

iNinja requested a review from a team as a code owner

September 23, 2024 13:51

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

FuPingFranco reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

FuPingFranco reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

FuPingFranco reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

sruke reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

sruke reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs

+                                  {
+                                      TokenValidationParameters = CreateTokenValidationParameters(null),
+                                      ValidationParameters = CreateValidationParameters(null),
+                                      Audience = string.Empty,

Contributor

sruke Sep 24, 2024

nit: Should this be a valid Audience while the Audiences property on TVP or VP is null?

Contributor Author

iNinja Sep 24, 2024

The current validation path considers the case where no valid audiences are provided to be invalid and throws.
The new validation path took that as a base and kept the same behaviour.

If you believe that having no valid audiences should be considered the same as skipping the validation, we can look into it and find out what the correct behaviour would be.


          Remove whitespace

8d2dba3

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

iNinja added 8 commits

September 26, 2024 13:01


          Cherry picked common functionality extraction from Lifetime branch

2f98fc7


          Added AudienceValidationError to handle custom exception properties

c3ee1e7


          Added delegates to skip validations

cef517e


          Removed token signing from audience validation tests, skipping all va…

57079d9

…lidations but audience


          Merge branch 'dev' into iinglese/regression-tests-audience

f0ea745


          Updated validation delegate names

dd83685


          Updated header being written in tests

b6c4385


          Merge branch 'dev' into iinglese/regression-tests-audience

d518e5f

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/AudienceValidationError.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/Validators.SkipValidations.cs Outdated Show resolved Hide resolved

This was referenced Nov 28, 2025

Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#497

Closed

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#498

Closed

Bump System.IdentityModel.Tokens.Jwt from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#501

Closed

Bump the patch-updates group with 2 updates DEFRA/waste-organisations#11

Merged

This was referenced Dec 8, 2025

Bump Microsoft.IdentityModel.Abstractions from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#511

Closed

Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#512

Closed

Bump Microsoft.IdentityModel.Logging from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#513

Closed

Bump Microsoft.IdentityModel.Protocols from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#514

Closed

Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#515

Closed

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#516

Closed

Bump System.IdentityModel.Tokens.Jwt from 8.0.1 to 8.15.0 statisticsnorway/PxWeb#518

Closed

Bump Microsoft.ApplicationInsights.Kubernetes and System.IdentityModel.Tokens.Jwt NatYou345/eShopOnContainers#585

Closed

Bump System.IdentityModel.Tokens.Jwt from 7.4.1 to 8.15.0 NatYou345/eShopOnWeb#124

Closed

This was referenced Dec 21, 2025

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.15.0 actions-marketplace-validations/joelverhagen_oidc-login#24

Closed

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.15.0 actions-marketplace-validations/joelverhagen_token-login#34

Closed

This was referenced Jan 12, 2026

deps: Bump NSubstitute and 4 others honua-io/honua-server#247

Closed

Bump Microsoft.Identity.Web and 2 others DFE-Digital/teaching-record-system#2976

Closed

deps: Bump Microsoft.AspNetCore.Authentication.JwtBearer and 6 others honua-io/honua-server#248

Closed

This was referenced Jan 21, 2026

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.15.0 henkkoetsier/wallet-connect-sharp#1

Open

Bump Microsoft.IdentityModel.Tokens from 8.0.2 to 8.15.0 Farhan-Labib-afk/Student-Life-OS#25

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt Farhan-Labib-afk/Student-Life-OS#28

Open

dependabot bot mentioned this pull request

nuget: Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.15.0 xinitrcn1/ryujinx-mirror-quartic#15

Closed

This was referenced Feb 9, 2026

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.15.0 openwallet-foundation-labs/wallet-framework-dotnet#502

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt openwallet-foundation-labs/wallet-framework-dotnet#505

Closed

Bump System.IdentityModel.Tokens.Jwt from 8.0.2 to 8.16.0 Cademic/ASideNote#20

Merged

nuget: Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.16.0 xinitrcn1/ryujinx-mirror-quartic#18

Open

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.16.0 actions-marketplace-validations/joelverhagen_oidc-login#30

Open

This was referenced Feb 16, 2026

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.16.0 actions-marketplace-validations/joelverhagen_token-login#40

Open

Bump System.IdentityModel.Tokens.Jwt from 7.4.1 to 8.16.0 NatYou345/eShopOnWeb#184

Open

nuget: Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.16.0 devz906/MelonJR#15

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kllysng kllysng left review comments

FuPingFranco FuPingFranco approved these changes

+3 more reviewers

brentschmaltz brentschmaltz left review comments

sruke sruke left review comments

jennyf19 jennyf19 approved these changes

Labels

None yet