Removed multiple public apis#2888
Merged
Merged
Conversation
revised how exceptions are created
jennyf19
approved these changes
Oct 8, 2024
Contributor
jennyf19
left a comment
jennyf19
left a comment
There was a problem hiding this comment.
pulled locally and ran the tests, the .txt look good
would be good to get another set of eyes though
Contributor
|
Can you link when these APIs were introduced? Or otherwise show some diff showing that these specific areas were touched? |
jmprieur
approved these changes
Oct 8, 2024
Contributor
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Thanks @brentschmaltz
westin-m
approved these changes
Oct 8, 2024
Collaborator
|
LGTM. Internal SecurityTokenException.ValidationError was removed by #2818, but looks like it wasn't used anywhere. |
14 tasks
This was referenced Aug 6, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Mar 30, 2026
Closed
This was referenced Apr 11, 2026
This was referenced Apr 29, 2026
Closed
Open
This was referenced May 7, 2026
Open
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We inadvertently shipped some public api's that are not ready, some were breaking modifications.
We removed the interface ISecurityTokenException (breaking)
SecurityTokenException.SetValidationError(ValidationError validationError) was changed internal
public class ValidationError was changed to internal
classes AudienceValidationError and LifetimeValidationError were modified to accept specific values in ctor removing the need for AdditionalInfo.