Skip to content

Regression tests: Token Type#2932

Merged
iNinja merged 11 commits intodevfrom
iinglese/regression-tests-token-type
Oct 24, 2024
Merged

Regression tests: Token Type#2932
iNinja merged 11 commits intodevfrom
iinglese/regression-tests-token-type

Conversation

@iNinja
Copy link
Contributor

@iNinja iNinja commented Oct 23, 2024

Regression tests: Token Type

  • Added TokenTypeValidationError to create the exception and assign the invalid token type.
  • Renamed ValidationParameters.TypeValidator to ValidationParameters.TokenTypeValidator
  • Adjusted the creation of SecurityTokenInvalidTypeException to return the correct invalid type when it is empty or null
  • Added regression/comparison tests for token type validation scenarios

Resolves #2914

Part of #2711

@iNinja iNinja requested a review from a team as a code owner October 23, 2024 14:58
Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment regarding the breaking change in ValidationParameters

Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iNinja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comparison tests for Token Type validation in new validation model

3 participants

Comments