Conversation
|
I think this might be a build step. At least it would make sense to be one to me instead of a unit test. |
|
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Thanks @kellyyangsong
Do we understand why it was skipped in the first place?
@jmprieur yes, thanks for asking, I should have explained in a comment. It was skipped because it would timeout which for this test is taking longer than 3 min in the ADO build. I re-ran this many times and never saw it take longer than 50s to complete. |
We have an analyzer that will cause warnings - but I still think this test is useful until we start treating warnings as errors. |
The test is passing locally without issue. Running an ADO PR build to ensure it passes there too.
Update - test passed in ADO build with no issues, running again
Update again - passed again