Skip to content

Restore skipped test: ReferenceCountingTest_MultiThreaded#2952

Merged
kllysng merged 1 commit intodevfrom
kellysong/restore-rCTMultiThreaded
Oct 30, 2024
Merged

Restore skipped test: ReferenceCountingTest_MultiThreaded#2952
kllysng merged 1 commit intodevfrom
kellysong/restore-rCTMultiThreaded

Conversation

@kllysng
Copy link
Contributor

@kllysng kllysng commented Oct 30, 2024

This test was previously skipped due to "too long". How long is too long? This takes an average of 300 ms to complete when I run it locally, aka 0.3 s.

@kllysng kllysng requested a review from a team as a code owner October 30, 2024 18:08
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @kellyyangsong

@kllysng kllysng merged commit 160a81d into dev Oct 30, 2024
@kllysng kllysng deleted the kellysong/restore-rCTMultiThreaded branch October 30, 2024 18:28
@jennyf19 jennyf19 added this to the 8.2.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments