Update cgmanifest to align with the JSON schema#2969
Merged
brentschmaltz merged 1 commit intoAzureAD:devfrom Nov 7, 2024
Merged
Update cgmanifest to align with the JSON schema#2969brentschmaltz merged 1 commit intoAzureAD:devfrom
brentschmaltz merged 1 commit intoAzureAD:devfrom
Conversation
jennyf19
approved these changes
Nov 1, 2024
JoshLozensky
approved these changes
Nov 1, 2024
pmaytak
approved these changes
Nov 1, 2024
Contributor
Author
|
FYI after merging dotnet/runtime#109453 with the same change, I dug in to understand why/how the component governance integration was still working despite the JSON document not adhering to the schema. I was able to confirm that it was working before, and it's still working after this change. The reason it worked is that the component detection that processes these files has the JSON deserialization set up where it is recognizing either TitleCase or properCase property names. So while it was working before, we're now adhering to the schema correctly and we won't get tripped up if the component detection ever applies stricter validation of the documents. |
This was referenced Aug 6, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Dec 8, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0
statisticsnorway/PxWeb#515
Closed
This was referenced Jan 21, 2026
This was referenced Feb 9, 2026
Closed
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With dotnet/machinelearning#7283, we realized that the
cgmanifest.jsonfile was not aligned with the JSON schema. It is using Title case property names but it should be using camelCase property names. See this comment for more detail: dotnet/machinelearning#7283 (comment)I'm following up by updating each CG manifest in the dotnet org where we had the same issue, and this match was found at https://github.com/dotnet/dotnet/blob/main/src/source-build-externals/src/azure-activedirectory-identitymodel-extensions-for-dotnet/build/cgmanifest.json.
Here's the console app I used to confirm the existing manifest isn't valid against its schema, and the updated one in this PR is valid:
Here's the output: