JsonWebTokenHandler IssuerExtensibility#2987
Merged
brentschmaltz merged 2 commits intodevfrom Nov 8, 2024
Merged
Conversation
SummarySummary
CoverageMicrosoft.IdentityModel.Abstractions - 70.2%
Microsoft.IdentityModel.JsonWebTokens - 80%
Microsoft.IdentityModel.Logging - 74.9%
Microsoft.IdentityModel.Protocols - 88.2%
Microsoft.IdentityModel.Protocols.OpenIdConnect - 81.4%
Microsoft.IdentityModel.Protocols.SignedHttpRequest - 93.4%
Microsoft.IdentityModel.Protocols.Tests - 0%
Microsoft.IdentityModel.Protocols.WsFederation - 80.9%
Microsoft.IdentityModel.TestUtils - 86.9%
Microsoft.IdentityModel.Tokens - 76.4%
Microsoft.IdentityModel.Tokens.Saml - 71.1%
Microsoft.IdentityModel.Tokens.Tests - 4.6%
Microsoft.IdentityModel.Validators - 95.8%
Microsoft.IdentityModel.Xml - 79.3%
System.IdentityModel.Tokens.Jwt - 83.8%
System.IdentityModel.Tokens.Jwt.Tests - 20.1%
|
src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/IssuerValidationError.cs
Show resolved
Hide resolved
48b9e88 to
079cbad
Compare
SummarySummary
CoverageMicrosoft.IdentityModel.Abstractions - 70.2%
Microsoft.IdentityModel.JsonWebTokens - 80%
Microsoft.IdentityModel.Logging - 74.9%
Microsoft.IdentityModel.Protocols - 88.2%
Microsoft.IdentityModel.Protocols.OpenIdConnect - 81.4%
Microsoft.IdentityModel.Protocols.SignedHttpRequest - 93.4%
Microsoft.IdentityModel.Protocols.Tests - 0%
Microsoft.IdentityModel.Protocols.WsFederation - 80.9%
Microsoft.IdentityModel.TestUtils - 86.9%
Microsoft.IdentityModel.Tokens - 76.4%
Microsoft.IdentityModel.Tokens.Saml - 70.9%
Microsoft.IdentityModel.Tokens.Tests - 4.6%
Microsoft.IdentityModel.Validators - 95.8%
Microsoft.IdentityModel.Xml - 79.3%
System.IdentityModel.Tokens.Jwt - 83.8%
System.IdentityModel.Tokens.Jwt.Tests - 20.1%
|
keegan-caruso
approved these changes
Nov 8, 2024
Contributor
keegan-caruso
left a comment
There was a problem hiding this comment.
Just some small things, but nothing functionally blocking
...soft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Common.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.TestUtils/CustomValidationDelegates.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.TestUtils/CustomValidationDelegates.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.TestUtils/CustomValidationDelegates.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.Issuer.Extensibility.cs
Show resolved
Hide resolved
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.Issuer.Extensibility.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.Abstractions - 70.2%
Microsoft.IdentityModel.JsonWebTokens - 80%
Microsoft.IdentityModel.Logging - 74.9%
Microsoft.IdentityModel.Protocols - 88.2%
Microsoft.IdentityModel.Protocols.OpenIdConnect - 81.4%
Microsoft.IdentityModel.Protocols.SignedHttpRequest - 93.4%
Microsoft.IdentityModel.Protocols.Tests - 0%
Microsoft.IdentityModel.Protocols.WsFederation - 80.9%
Microsoft.IdentityModel.TestUtils - 86.9%
Microsoft.IdentityModel.Tokens - 76.4%
Microsoft.IdentityModel.Tokens.Saml - 70.7%
Microsoft.IdentityModel.Tokens.Tests - 4.6%
Microsoft.IdentityModel.Validators - 95.8%
Microsoft.IdentityModel.Xml - 79.3%
System.IdentityModel.Tokens.Jwt - 83.8%
System.IdentityModel.Tokens.Jwt.Tests - 20.1%
|
This was referenced Aug 6, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Aug 15, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.1
statisticssweden/PxWeb#706
Closed
This was referenced Dec 8, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0
statisticsnorway/PxWeb#515
Closed
This was referenced Jan 21, 2026
This was referenced Feb 9, 2026
Closed
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for IssuerExtensibility to understand the user experience.
Some improvements to the call graph, but those were small.