Skip to content

Prevent inlining to guarantee stack frames in test#3002

Merged
westin-m merged 3 commits intodevfrom
westin/flakyStack
Nov 14, 2024
Merged

Prevent inlining to guarantee stack frames in test#3002
westin-m merged 3 commits intodevfrom
westin/flakyStack

Conversation

@westin-m
Copy link
Contributor

Addresses #2999

In release builds, the compiler was inlining the methods that only contained call to other methods. This was causing the stack trace to be different than expected. Specifying no inlining will prevent this.

@westin-m westin-m requested a review from a team as a code owner November 13, 2024 23:26
@msbw2 msbw2 requested a review from iNinja November 13, 2024 23:38
@westin-m westin-m merged commit 658e4e5 into dev Nov 14, 2024
@westin-m westin-m deleted the westin/flakyStack branch November 14, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flaky test] ValidationErrorTests.ExceptionCreatedFromValidationError_ContainsTheRightStackTrace flaky test

3 participants

Comments