Avoid code duplication in extensibility testing#3041
Merged
brentschmaltz merged 7 commits intodevfrom Nov 28, 2024
Merged
Conversation
…ve SecurityToken instead of Saml(2)SecurityToken
…andler and Saml2SecurityTokenHandler's ValidateTokenAsync and CreateToken methods under a shared API
…y data. Added ValidateTokenAsyncExtensibility to test all extensibility aspects across JWT, SAML, and SAML2
…T, SAML, and SAML2 using the new test classes
msbw2
reviewed
Nov 27, 2024
...rosoft.IdentityModel.TestUtils/TokenValidationExtensibility/Tests/ExtensibilityTheoryData.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 27, 2024
...rosoft.IdentityModel.TestUtils/TokenValidationExtensibility/Tests/ExtensibilityTheoryData.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 27, 2024
...rosoft.IdentityModel.TestUtils/TokenValidationExtensibility/Tests/ExtensibilityTheoryData.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Nov 27, 2024
...rosoft.IdentityModel.TestUtils/TokenValidationExtensibility/Tests/ExtensibilityTheoryData.cs
Show resolved
Hide resolved
msbw2
reviewed
Nov 27, 2024
...t.IdentityModel.TestUtils/TokenValidationExtensibility/Tests/IssuerExtensibilityTestCases.cs
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Nov 27, 2024
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.ValidateToken.Internal.cs
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Nov 27, 2024
...icrosoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateToken.Internal.cs
Show resolved
Hide resolved
Co-authored-by: msbw2 <brettwhite@microsoft.com>
Contributor
|
This is a good pass at code reduction. |
|
"SUBSCRIBED"
***@***.***
3345126497
MPSS.HA.1.1.c1-00015-1.484352.3.486950.2,MPSS.HA.1.1.c1-00015-1.484352.3.486950.2
El mié., 27 de noviembre de 2024 21:57, BrentSchmaltz <
***@***.***> escribió:
… Merged #3041
<#3041>
into dev.
—
Reply to this email directly, view it on GitHub
<#3041 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFLCBZ5J3Z7M4DIGDN2ZCVT2C2ICFAVCNFSM6AAAAABSTHMZZOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGQ2TSOBVGU3TQNA>
.
You are receiving this because you are subscribed to this thread.Message
ID:
<AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/3041/issue_event/15459855784
@github.com>
|
This was referenced Aug 6, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Jan 10, 2026
This was referenced Jan 19, 2026
Closed
This was referenced Jan 27, 2026
This was referenced Feb 4, 2026
Closed
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid code duplication in extensibility testing
ValidateTokenAsyncinSAMLandSAML2token handlers to receiveSecurityTokeninstead ofSamlSecurityToken/Saml2SecurityTokenJsonWebTokenHandler,SamlSecurityTokenHandlerandSaml2SecurityTokenHandler'sValidateTokenAsyncandCreateTokenmethods under a shared APIExtensibilityTheoryDataas the base for all extensibility theory data.ValidateTokenAsyncExtensibilityto test all extensibility aspects acrossJWT,SAML, andSAML2JWT,SAML, andSAML2using the new test classes