Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds negative test cases for the 'alg' header claim to ensure proper rejection of insecure or invalid algorithm values like 'none' and 'noNe'. This helps prevent security regressions where these algorithms might be inadvertently accepted.
- Adds test cases for "none" and "noNe" algorithm values across all supported key types
- Ensures these insecure algorithms are properly rejected (expected result: false)
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
test/Microsoft.IdentityModel.Tokens.Tests/SupportedAlgorithmTests.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
pmaytak
approved these changes
Aug 15, 2025
mdchennu
approved these changes
Aug 18, 2025
saurabhsathe-ms
approved these changes
Aug 18, 2025
This was referenced Nov 20, 2025
Closed
Closed
Merged
This was referenced Feb 9, 2026
Closed
Closed
Closed
Merged
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds negative test cases for the 'alg' header claim to ensure proper rejection of insecure or invalid algorithm values like 'none' and 'noNe'. This helps prevent security regressions where these algorithms might be inadvertently accepted.
Adds test cases for "none" and "noNe" algorithm values across all supported key types
Ensures these insecure algorithms are properly rejected (expected result: false)