Avoid broadcasting over a Q matrix#17
Merged
matthewware merged 2 commits intoBBN-Q:masterfrom Sep 17, 2022
dkarrasch:patch-1
Merged
Avoid broadcasting over a Q matrix#17matthewware merged 2 commits intoBBN-Q:masterfrom dkarrasch:patch-1
Q matrix#17matthewware merged 2 commits intoBBN-Q:masterfrom
dkarrasch:patch-1
Conversation
Contributor
Author
|
Gentle bump. |
matthewware
reviewed
Sep 15, 2022
Collaborator
|
@gribeill I'll go ahead and merge this feel free to revert or modify. @dkarrasch Thank you for the PR |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 60 60
=========================================
Hits 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in a nanosoldier run related to JuliaLang/julia#46196. Broadcasting over a
Qmatrix is superslow because it falls back to elementwisegetindex. My proposal computes the full (square) matrix representation, and subsequently overwrites temporary storage. Especially for largeX, this should speed up the function quite significantly.