Merged
Conversation
Contributor
|
Yes, it is bogus. The nested OpenCV guard supersedes the outer, didn't see this, sorry about that. |
Member
Author
|
No worries. Thanks for confirming.
|
shelhamer
force-pushed
the
test-layer-type-upgrade
branch
from
7590f7f to
33a8ba6
Compare
shelhamer
added a commit
that referenced
this pull request
Oct 19, 2015
[test] drop bogus OpenCV guard for layer type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V1 layer type test should always be run regardless of the IO dependencies.
@eelstork can you explain your thinking in f3a933a? Let me know if this is somehow needed.