Skip to content

Conversation

@krushnarout
Copy link
Member

@krushnarout krushnarout commented Sep 7, 2025

Bugs:

  • highlighted text gets hidden behind the search bar
  • search does not work on long transcripts
  • can't scroll pages when the search bar is open

closes #2907

@krushnarout
Copy link
Member Author

  • highlighted text gets hidden behind the search bar
Screen_Recording_20250907_114046_Omi.Dev.mp4

@krushnarout krushnarout marked this pull request as draft September 7, 2025 06:29
@krushnarout
Copy link
Member Author

  • can't scroll pages when the search bar is open
Screen_Recording_20250909_230500_Omi.Dev.mp4

@krushnarout
Copy link
Member Author

  • search does not work on long transcripts
Screen_Recording_20250910_005515_Omi.Dev.mp4

@krushnarout krushnarout marked this pull request as ready for review September 9, 2025 19:31
@aaravgarg aaravgarg requested review from mdmohsin7 and removed request for aaravgarg September 10, 2025 00:02
@aaravgarg
Copy link
Collaborator

@mdmohsin7 pls test on physical ios device

@mdmohsin7
Copy link
Member

ScreenRecording_09-10-2025.16-33-00_1.MP4

Sometimes the searched text does not seem to get highlighted, it only seems to happen when there are too many occurrences of the text

@beastoin
Copy link
Collaborator

lgtm @krushnarout .

next, test main carefully and try to reproduce Mohsin’s cases and fix them. i guess you could also use his dev account if needed.

@krushnarout
Copy link
Member Author

lgtm @krushnarout .

next, test main carefully and try to reproduce Mohsin’s cases and fix them. i guess you could also use his dev account if needed.

@beastoin I've fixed it and opened a PR #2986 I don't have an iOS device for testing . could you please test it? I did test it on Android, and it's working fine.

@krushnarout krushnarout deleted the fix/search-bar branch September 13, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search does not work on long transcripts that contain multiple transcript segments.

4 participants