Skip to content

Conversation

@krushnarout
Copy link
Member

closes #3534

RPReplay_Final1764905502.MP4

@krushnarout krushnarout requested a review from mdmohsin7 December 5, 2025 03:48
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where the speech profile card was not hidden after a user creates a speech profile. The change updates the UI state appropriately. I have included one high-severity comment to address a potential race condition and an unhandled asynchronous operation in the surrounding code, which could lead to silent failures or an inconsistent UI state. The suggested code change resolves these issues, making the implementation more robust.

@mdmohsin7
Copy link
Member

I think the main issue is that sometimes after it reaches 100% it still gets stuck at 100% and does not move forward, that is the all done button doesn't appear

@krushnarout
Copy link
Member Author

I think the main issue is that sometimes after it reaches 100% it still gets stuck at 100% and does not move forward, that is the all done button doesn't appear

I have tested it, it's working fine

RPReplay_Final1764995556.mov

my fix is after clicking on all done, the "teach omi your voice" still stays there, but it supposed to disappear

IMG_EF293C7A6FD9-1

@mdmohsin7
Copy link
Member

nvm this is a different issue, I did not read it correctly

@mdmohsin7 mdmohsin7 merged commit 52306f5 into main Dec 6, 2025
1 check passed
@mdmohsin7 mdmohsin7 deleted the fix/speaker-profile branch December 6, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"teach omi your voice" doesn't disappear after I teach it my voice

3 participants