Fix division by 0 issue when all scores are zero#24
Open
AlanKerstjens wants to merge 1 commit intoBenevolentAI:masterfrom
Open
Fix division by 0 issue when all scores are zero#24AlanKerstjens wants to merge 1 commit intoBenevolentAI:masterfrom
AlanKerstjens wants to merge 1 commit intoBenevolentAI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
graph_ga/goal_directed_generation.pythe mating pool is selected through weighted random sampling, with the probability of a molecule being selected given by its score divided by the sum of all scores (sum_scores).guacamol_baselines/graph_ga/goal_directed_generation.py
Lines 25 to 42 in 44d24c5
If
sum_scores == 0.0we get a division by 0. This actually occurs during the Valsartan SMARTS benchmark when using random starting molecules due to its binary nature.