Resolve a minor TODO #177
Merged
Resolve a minor TODO #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonachea
force-pushed
the
base_pointer-todo
branch
from
e6382b2 to
075b11b
Compare
ktras
requested changes
Mar 4, 2025
Collaborator
ktras
left a comment
ktras
left a comment
There was a problem hiding this comment.
Looks great, just one minor suggestion since I think num_img is now an unused variable.
This is a left-over from pull request BerkeleyLab#171 and BerkeleyLab#172 that was only possible to fully resolve now they are both merged.
Co-authored-by: Katherine Rasmussen <[email protected]>
bonachea
force-pushed
the
base_pointer-todo
branch
from
43ca7c2 to
71f4897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a left-over from pull request #171 and #172 that was only possible to fully resolve now they are both merged.