docs: document default_team_params in config reference#25032
docs: document default_team_params in config reference#25032ryan-crabbe-berri merged 2 commits intolitellm_ryan-march-31from
Conversation
- Add default_team_params to litellm_settings reference table in config_settings.md with all sub-fields documented - Update self_serve.md and msft_sso.md examples to include team_member_permissions, tpm_limit, and rpm_limit - Fix misleading comment that implied default_team_params only applies to SSO auto-created teams — it applies to all /team/new calls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis is a pure documentation PR that adds The documentation changes are accurate and consistent with the implementation:
The previous Greptile finding about Confidence Score: 5/5Documentation-only PR; all sub-field descriptions and applicability scopes have been verified against the implementation and are accurate. No code changes are introduced. All documented sub-fields, their types, and their scope (SSO-only vs. all No files require special attention.
|
| Filename | Overview |
|---|---|
| docs/my-website/docs/proxy/config_settings.md | Adds a new default_team_params row to the litellm_settings reference table; sub-fields and their applicability scope are accurately described and match the source code in team_endpoints.py and ui_sso.py. |
| docs/my-website/docs/proxy/self_serve.md | Updates two YAML code examples to include tpm_limit, rpm_limit, and team_member_permissions; also corrects the misleading comment that implied default_team_params was SSO-only. Minor inconsistency: the second comprehensive config block omits inline comments and the second permission route present in the first example. |
| docs/my-website/docs/tutorials/msft_sso.md | Updates the Microsoft SSO config example to include team_member_permissions, aligning it with the other updated examples. Changes are accurate and non-breaking. |
Reviews (2): Last reviewed commit: "docs: clarify that models sub-field only..." | Re-trigger Greptile
| | enable_json_schema_validation | boolean | If true, enables json schema validation for all requests. | | ||
| | enable_key_alias_format_validation | boolean | If true, validates `key_alias` format on `/key/generate` and `/key/update`. Must be 2-255 chars, start/end with alphanumeric, only allow `a-zA-Z0-9_-/.@`. Default `false`. | | ||
| | disable_copilot_system_to_assistant | boolean | **DEPRECATED** - GitHub Copilot API supports system prompts. | | ||
| | default_team_params | object | Default parameters applied to every new team created via `/team/new` (including SSO auto-created teams). Only fills in fields not explicitly set in the request. Sub-fields: `max_budget` (float), `budget_duration` (string, e.g. `"30d"`), `models` (array of strings), `tpm_limit` (integer), `rpm_limit` (integer), `team_member_permissions` (array of strings, e.g. `["/team/daily/activity", "/key/generate"]`). | |
There was a problem hiding this comment.
models sub-field does not apply to all /team/new calls
The description states that default_team_params "Default parameters applied to every new team created via /team/new", and lists models as a sub-field. However, in litellm/proxy/management_endpoints/team_endpoints.py (lines 862–868), the loop that backfills defaults only iterates over max_budget, budget_duration, tpm_limit, rpm_limit, and team_member_permissions — models is deliberately excluded:
for field in (
"max_budget",
"budget_duration",
"tpm_limit",
"rpm_limit",
"team_member_permissions",
):models is applied for SSO-created teams because ui_sso.py copies all DefaultTeamSSOParams fields into the NewTeamRequest before calling new_team(). But a user making a direct POST /team/new request without specifying models will not have models populated from default_team_params.
The documentation should either clarify that the models field only takes effect for SSO auto-created teams, or "models" should be added to the loop in team_endpoints.py to make the behaviour consistent with the documented claim.
The same note should be added to self_serve.md (line ~364) and msft_sso.md (line ~134) wherever models appears under default_team_params.
eb780a8
into
litellm_ryan-march-31
…am-params docs: document default_team_params in config reference
Summary
default_team_paramsto thelitellm_settingsreference table inconfig_settings.mdwith all sub-fields documentedself_serve.mdandmsft_sso.mdconfig examples to includeteam_member_permissions,tpm_limit, andrpm_limitdefault_team_paramsonly applies to SSO auto-created teams — it applies to all/team/newcallsTest plan