[Infra] Remove flaky proxy_e2e_azure_batches_tests CI workflow#25247
[Infra] Remove flaky proxy_e2e_azure_batches_tests CI workflow#25247ishaan-berri merged 1 commit intomainfrom
Conversation
The proxy_e2e_azure_batches_tests workflow is consistently flaky and does not provide reliable signal on whether changes break anything. Remove the workflow from both CircleCI and GitHub Actions, along with the test directory it exclusively used. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Greptile SummaryThis PR removes the consistently flaky
Confidence Score: 5/5Safe to merge — pure deletion of a flaky CI workflow and its test directory with no impact on production code. This is a straightforward infrastructure cleanup consisting entirely of deletions. No production or library code is touched, no other CI jobs reference the removed workflow or test directory (verified by codebase-wide search), and the CircleCI config correctly retains all other workflow triggers. There are no P0 or P1 findings. No files require special attention.
|
| Filename | Overview |
|---|---|
| .circleci/config.yml | Removes the proxy_e2e_azure_batches_tests job definition (~114 lines) and its workflow trigger; all other CircleCI jobs are untouched |
| .github/workflows/test-proxy-e2e-azure-batches.yml | Entire GitHub Actions workflow file deleted; was the GHA counterpart running the same flaky E2E suite |
| tests/proxy_e2e_azure_batches_tests/test_proxy_e2e_azure_batches.py | Deleted primary E2E test file (~324 lines) exclusively used by the removed CI workflow |
| tests/proxy_e2e_azure_batches_tests/test_managed_files_base.py | Largest deleted file (~1,085 lines) containing base-class tests for managed file operations in the Azure batch suite |
| tests/proxy_e2e_azure_batches_tests/fixtures/mock_azure_batch_server/mock_azure_batch.py | Deleted mock server implementation (~517 lines) simulating Azure Batch API responses; no longer needed |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR merged to main] --> B{CI Triggers}
B --> C[CircleCI Workflows]
B --> D[GitHub Actions Workflows]
C --> E[Remaining CircleCI jobs\ne.g. llm_translation_testing, upload-coverage...]
C --> F[proxy_e2e_azure_batches_tests\n❌ REMOVED]
D --> G[Remaining GHA workflows]
D --> H[test-proxy-e2e-azure-batches.yml\n❌ REMOVED]
style F fill:#ffcccc,stroke:#cc0000,color:#000000
style H fill:#ffcccc,stroke:#cc0000,color:#000000
Reviews (1): Last reviewed commit: "Remove flaky proxy_e2e_azure_batches_tes..." | Re-trigger Greptile
The proxy_e2e_azure_batches_tests workflow is consistently flaky and does not provide reliable signal on whether changes break anything. Remove the workflow from both CircleCI and GitHub Actions, along with the test directory it exclusively used. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Problem
The
proxy_e2e_azure_batches_testsworkflow is consistently flaky — it fails intermittently regardless of code changes, providing no reliable signal on whether a PR actually breaks anything. This leads to wasted CI minutes, unnecessary re-runs, and developer friction when legitimate PRs are blocked by unrelated test failures.Fix
Remove the
proxy_e2e_azure_batches_testsworkflow entirely from both CircleCI and GitHub Actions, along with the test directory it exclusively used.Changes
proxy_e2e_azure_batches_testsjob definition from.circleci/config.yml.github/workflows/test-proxy-e2e-azure-batches.ymltests/proxy_e2e_azure_batches_tests/directory (all test files, fixtures, mock servers)No other tests or workflows referenced this directory, so no other CI jobs are affected.
Type
🚄 Infrastructure