[Infra] Remove Redundant Matrix Unit Test Workflow#25251
Conversation
All test paths in test-litellm-matrix.yml are fully covered by the newer semantic unit test workflows (test-unit-*.yml), making the matrix workflow redundant CI spend. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Greptile SummaryThis PR removes the redundant
Confidence Score: 5/5Safe to merge — all changes are confined to GitHub Actions workflow files with no production code impact All 15 changed files are GitHub Actions YAML. The matrix workflow deletion is cleanly mapped to existing semantic workflows. Coverage instrumentation is additive and non-blocking (fail_ci_if_error: false). The only finding is a P2 inconsistency in the artifact-name default between the two base templates, which does not affect any current caller. P2-only findings warrant a 5/5 score. _test-unit-services-base.yml has a minor required: false vs required: true inconsistency for artifact-name relative to _test-unit-base.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/test-litellm-matrix.yml | Deleted — redundant matrix test workflow replaced 1:1 by the existing semantic unit test workflows |
| .github/workflows/_test-unit-base.yml | Added required artifact-name input, pytest-cov coverage flags, artifact upload, and a new upload-coverage job with OIDC-based Codecov integration |
| .github/workflows/_test-unit-services-base.yml | Same coverage/Codecov additions as _test-unit-base.yml; artifact-name is optional with default 'run' (inconsistent with _test-unit-base.yml's required: true) |
| .github/workflows/test-unit-proxy-db.yml | Added job-level id-token/pull-requests write permissions and unique per-matrix-group artifact names for coverage upload |
| .github/workflows/test-unit-llm-providers.yml | Added job-level id-token/pull-requests write permissions and unique artifact names for vertex-ai and other-providers jobs |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Pull Request / Push] --> WF1[test-unit-llm-providers.yml]
PR --> WF2[test-unit-proxy-auth.yml]
PR --> WF3[test-unit-proxy-endpoints.yml]
PR --> WF4[test-unit-proxy-infra.yml]
PR --> WF5[test-unit-misc.yml]
PR --> WF6[test-unit-enterprise-routing.yml]
PR --> WF7[test-unit-integrations.yml]
PR --> WF8[test-unit-responses-caching-types.yml]
PUSH[Push to main] --> WF9[test-unit-proxy-db.yml]
PUSH --> WF10[test-unit-caching-redis.yml]
PUSH --> WF11[test-unit-security.yml]
WF1 --> BASE[_test-unit-base.yml]
WF2 --> BASE
WF3 --> BASE
WF4 --> BASE
WF5 --> BASE
WF6 --> BASE
WF7 --> BASE
WF8 --> BASE
WF9 --> SBASE[_test-unit-services-base.yml]
WF10 --> SBASE
WF11 --> SBASE
BASE --> RUN1[job: run\npytest + --cov]
BASE --> UP1[job: upload-coverage\nOIDC to Codecov]
SBASE --> RUN2[job: run\npytest + --cov]
SBASE --> UP2[job: upload-coverage\nOIDC to Codecov]
RUN1 -->|coverage artifact| UP1
RUN2 -->|coverage artifact| UP2
DELETED[~~test-litellm-matrix.yml~~ DELETED]
style DELETED fill:#ffcccc,stroke:#cc0000
Reviews (3): Last reviewed commit: "Move id-token/pull-requests permissions ..." | Re-trigger Greptile
Add coverage collection (--cov) and Codecov OIDC upload to both reusable base workflows and all 12 caller workflows, replacing the coverage reporting that was previously only in the matrix workflow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rkflows For workflows with multiple jobs (llm-providers, proxy-db), move id-token: write and pull-requests: write from workflow level to job level so permissions are scoped to only the jobs that need them. Removes zizmor inline suppressions that were masking the issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Remove redundant matrix unit test workflow All test paths in test-litellm-matrix.yml are fully covered by the newer semantic unit test workflows (test-unit-*.yml), making the matrix workflow redundant CI spend. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add Codecov coverage reporting to semantic unit test workflows Add coverage collection (--cov) and Codecov OIDC upload to both reusable base workflows and all 12 caller workflows, replacing the coverage reporting that was previously only in the matrix workflow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Move id-token/pull-requests permissions to job level for multi-job workflows For workflows with multiple jobs (llm-providers, proxy-db), move id-token: write and pull-requests: write from workflow level to job level so permissions are scoped to only the jobs that need them. Removes zizmor inline suppressions that were masking the issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Problem
The
test-litellm-matrix.ymlworkflow duplicates all test coverage already provided by the newer semantic unit test workflows (test-unit-*.yml). This results in redundant CI spend on every PR.Fix
Remove
test-litellm-matrix.yml. Every matrix group maps 1:1 to an existing semantic workflow:test-unit-llm-providers.ymltest-unit-proxy-endpoints.ymltest-unit-proxy-auth.ymltest-unit-proxy-infra.ymltest-unit-integrations.ymltest-unit-core-utils.ymltest-unit-responses-caching-types.ymltest-unit-enterprise-routing.ymltest-unit-misc.ymltest-unit-proxy-legacy.ymlTesting
Type
🚄 Infrastructure