Skip to content

Add "Screenshots / Proof of Fix" section to PR template#25564

Merged
krrish-berri-2 merged 1 commit intomainfrom
cursor/pr-template-proof-section-0c94
Apr 11, 2026
Merged

Add "Screenshots / Proof of Fix" section to PR template#25564
krrish-berri-2 merged 1 commit intomainfrom
cursor/pr-template-proof-section-0c94

Conversation

@krrish-berri-2
Copy link
Copy Markdown
Contributor

Relevant issues

Prompted by Slack discussion about ensuring contributors demonstrate their fixes work.

Changes

Adds a new "Screenshots / Proof of Fix" section to the GitHub pull request template (.github/pull_request_template.md).

The section prompts contributors to include visual or log-based evidence that their changes work as expected, with guidance for different PR types:

  • Bug fixes: show reproduction before the fix and passing behavior after
  • New features: show the feature working end-to-end
  • UI changes: include before/after screenshots

The section is placed between the CI checklist and the Type selector, so contributors encounter it naturally while filling out the template.

Slack Thread

Open in Web Open in Cursor 

Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Apr 11, 2026 4:31pm

Request Review

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq bot commented Apr 11, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing cursor/pr-template-proof-section-0c94 (374036c) with main (4e12d3c)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@krrish-berri-2 krrish-berri-2 marked this pull request as ready for review April 11, 2026 16:37
@krrish-berri-2 krrish-berri-2 enabled auto-merge (squash) April 11, 2026 16:37
@krrish-berri-2 krrish-berri-2 disabled auto-merge April 11, 2026 16:37
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 11, 2026

Greptile Summary

This PR adds a "Screenshots / Proof of Fix" section to the GitHub PR template, prompting contributors to include visual or log-based evidence of their changes. The new section is well-placed and aligns with the repository's existing rule that PRs claiming to fix issues should include evidence of resolution.

Confidence Score: 5/5

Safe to merge — documentation-only template change with no code impact.

Single-file template addition with no logic, no security surface, and no regressions possible. Aligns with the team's existing rule on requiring proof-of-fix evidence.

No files require special attention.

Important Files Changed

Filename Overview
.github/pull_request_template.md Adds a "Screenshots / Proof of Fix" section between the CI checklist and Type selector; comment-only guidance with no required checkbox, making it optional for contributors.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Contributor opens PR] --> B[Fill out Relevant Issues]
    B --> C[Complete Pre-Submission Checklist]
    C --> D[CI Links — LiteLLM team]
    D --> E["📸 Screenshots / Proof of Fix (NEW)"]
    E --> F[Select PR Type]
    F --> G[Describe Changes]
    G --> H[Maintainer Review]
Loading

Reviews (1): Last reviewed commit: "Add Screenshots / Proof of Fix section t..." | Re-trigger Greptile

@krrish-berri-2 krrish-berri-2 merged commit 01b9b50 into main Apr 11, 2026
50 of 51 checks passed
@krrish-berri-2 krrish-berri-2 deleted the cursor/pr-template-proof-section-0c94 branch April 11, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants