Skip to content

Adding 200m structures to biopandas#105

Merged
rasbt merged 6 commits intoBioPandas:mainfrom
a-r-j:patch-1
Aug 6, 2022
Merged

Adding 200m structures to biopandas#105
rasbt merged 6 commits intoBioPandas:mainfrom
a-r-j:patch-1

Conversation

@a-r-j
Copy link
Contributor

@a-r-j a-r-j commented Aug 2, 2022

Small update to support AF2 v3.

Very high structure:code ratio in this PR 😁

@pep8speaks
Copy link

pep8speaks commented Aug 2, 2022

Hello @a-r-j! Thanks for updating this PR.

Line 83:54: W291 trailing whitespace
Line 84:89: E501 line too long (102 > 88 characters)
Line 119:17: E128 continuation line under-indented for visual indent
Line 119:89: E501 line too long (96 > 88 characters)

Line 148:13: W503 line break before binary operator
Line 163:13: W503 line break before binary operator

Line 131:54: W291 trailing whitespace
Line 132:89: E501 line too long (109 > 88 characters)
Line 168:17: E128 continuation line under-indented for visual indent
Line 168:89: E501 line too long (99 > 88 characters)

Line 154:13: W503 line break before binary operator
Line 172:13: W503 line break before binary operator

Comment last updated at 2022-08-06 04:25:25 UTC

@rasbt
Copy link
Member

rasbt commented Aug 4, 2022

Thanks a lot for the update!

@a-r-j
Copy link
Contributor Author

a-r-j commented Aug 4, 2022

It looks like tests are failing due to metadata changes in the local AF2 pdb/mmcif files. I'll fix this up.

@rasbt
Copy link
Member

rasbt commented Aug 5, 2022

Thanks! So it looks like they also updated the previous alphafold-v2 structures? If that's just the meta-data, theoretically we could also just check for Atom entries. Otherwise, I am not sure whether we would have to update the check every few months or so 😅

@a-r-j
Copy link
Contributor Author

a-r-j commented Aug 6, 2022

It looks like it was just metadata. They just changed the date in the PDB file. In the mmCIF there were more changes but coords are unaffected. I added another block to test for the latest release but updated the old test to make sure everything works nicely with retrieving structures from previous releases too.

@rasbt
Copy link
Member

rasbt commented Aug 6, 2022

Awesome, thanks!

@rasbt rasbt merged commit 092a6a8 into BioPandas:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants