Skip to content

b_factor one white space format fix#134

Merged
a-r-j merged 2 commits intoBioPandas:mainfrom
zehrasarica:fix/b_factor_white_space_shift
Jul 21, 2023
Merged

b_factor one white space format fix#134
a-r-j merged 2 commits intoBioPandas:mainfrom
zehrasarica:fix/b_factor_white_space_shift

Conversation

@zehrasarica
Copy link
Contributor

@zehrasarica zehrasarica commented Jul 16, 2023

Code of Conduct

Description

Related issues or pull requests

#133

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./biopandas/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under biopandas/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./biopandas -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./biopandas/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./biopandas

@a-r-j
Copy link
Contributor

a-r-j commented Jul 20, 2023

LGTM! Thanks for this contribution @zehraacarsarica

Would you be able to:

  1. Add a note to the CHANGELOG.md
  2. Write up a quick unit test

@zehrasarica
Copy link
Contributor Author

LGTM! Thanks for this contribution @zehraacarsarica

Would you be able to:

  1. Add a note to the CHANGELOG.md
  2. Write up a quick unit test

Thanks for your response @a-r-j . These files were updated accordingly.

@a-r-j
Copy link
Contributor

a-r-j commented Jul 21, 2023

Thanks @zehraacarsarica. LGTM!!

@a-r-j a-r-j merged commit 13e72a9 into BioPandas:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants