PPL: GeoIP function#347
Closed
andy-k-improving wants to merge 7 commits intoft-ak-geo-spatial-integrationfrom
Closed
PPL: GeoIP function#347andy-k-improving wants to merge 7 commits intoft-ak-geo-spatial-integrationfrom
andy-k-improving wants to merge 7 commits intoft-ak-geo-spatial-integrationfrom
Conversation
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
c54639c to
e9a4273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new PPL command expression
geoip, to perform geo-spatial information lookup with the provided IPv4 || IPv6 addresses, result of the lookup is formatted into a tuple with attribute as key and location detail as value.In this particular setting, SQL plugin will act as a thin client, by relaying the IPEnrichment request to OpenSearch Geo-Spatial plugin, WITHIN the same cluster.
Detail implementation and interface that exposed on Geo-Spatial side can be found:
opensearch-project/geospatial#700
Internally this functionality is achieved by:
OpenSearchFunctionExpressionmarker to identify this is an expression has no default implement on other runtime (Ex: Prometheus)OpenSearchIndexin order to provide an OpenSearch specific handler forevaloperator and its expressions, when OS being used as the storage engine.During runtime, all eval expressions, will being passed to
OpenSearchIndex.visitEval( ), thenOpenSearchEvalOperatorclass will pick up the call, by evaluating allevalexpression as it is, and then handle all occasion ofOpenSearchFunctionExpressionseparately, by reading the function name and argument, and execute the appropriate business logic.Marker class
OpenSearchFunctionExpressionis being used in this case because the actual implementation require runtime OpenSearch client connectivity, howevercoremodule is mean to be generic, hence this workaround is being deployed, by tagging it asOpenSearchFunctionExpressiononcoreand only handle it on theopensearchCradle module .Related Issues
Resolves: opensearch-project#3037
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.