Draft
Conversation
…itioned DML. Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
spotless:apply was not fixing error that spotless:check was reporting. Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
…nner/SpannerWriteBuilder.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
… "recreate" Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
…nner/SpannerWriteBuilder.java Temporary code. will be merged with catalog branch. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…g class. Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements an overwrite mode for Spark writes to Spanner, offering 'truncate' and 'recreate' strategies. The implementation is well-structured, adding new capabilities and refactoring existing code for better organization. I have a couple of suggestions to enhance robustness and exception handling.
spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerWriteBuilder.java
Show resolved
Hide resolved
Comment on lines
+92
to
+95
| } catch (InterruptedException | ExecutionException e) { | ||
| throw new SpannerConnectorException( | ||
| SpannerErrorCode.DDL_EXCEPTION, "Error recreating table " + tableName, e); | ||
| } |
There was a problem hiding this comment.
When an InterruptedException is caught, it's a best practice to restore the interrupted status of the thread by calling Thread.currentThread().interrupt(). This allows code higher up the call stack to be aware of the interruption and handle it appropriately.
Suggested change
| } catch (InterruptedException | ExecutionException e) { | |
| throw new SpannerConnectorException( | |
| SpannerErrorCode.DDL_EXCEPTION, "Error recreating table " + tableName, e); | |
| } | |
| } catch (InterruptedException | ExecutionException e) { | |
| if (e instanceof InterruptedException) { | |
| Thread.currentThread().interrupt(); | |
| } | |
| throw new SpannerConnectorException( | |
| SpannerErrorCode.DDL_EXCEPTION, "Error recreating table " + tableName, e); | |
| } |
…nner/SpannerWriteBuilder.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.