Custom Controls not loaded

[ReofSpa]

Describe the bug
I am using Amiberry release 7.0.8 (Fedora release on Nobara).
The games and programs are loaded via uae files.
For the game "Nitro" where the third driver is using the keyboard I want to map Right Shift to South, Dpad left to Z and Dpad right to x. Doing this in the GUI and going directly into the game is working fine.
When I save the configuration in the GUI something like "joyport?amiberry_custom*" is written to the uae file (sometimes double, JOY1 not at all).
This information is not read when loading the uae file the next time. The log claims that it does not know these kind of entries.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Custom Controls' and change the mapping for the specific joystick.
2. Go to 'Configurations' and save the configuration.
3. Restart Amiberry from console
4. Go to 'Paths' and enable 'Log to console'
5. Go to 'Configurations' and load the respective configuration
6. The console is spammed with INFO messages of unknown config entry

Expected behavior
It is expected that Amiberry not only writes the entries to the uae file, but can also read it in.

Screenshots

INFO: load config '/home/reofspa/Amiberry/conf/Nitro.uae':0
INFO: unknown config entry: 'joyport0_amiberry_custom_none_a='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_b='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_x='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_y='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_back='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_guide='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_start='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_leftstick='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_rightstick='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_leftshoulder='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_rightshoulder='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_dpup='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_dpdown='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_dpleft='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_dpright='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_misc1='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_paddle1='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_paddle2='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_paddle3='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_paddle4='
INFO: unknown config entry: 'joyport0_amiberry_custom_none_touchpad='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_none_leftx='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_none_lefty='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_none_rightx='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_none_righty='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_none_lefttrigger='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_none_righttrigger='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_a='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_b='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_x='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_y='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_back='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_guide='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_start='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_leftstick='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_rightstick='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_leftshoulder='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_rightshoulder='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_dpup='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_dpdown='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_dpleft='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_dpright='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_misc1='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_paddle1='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_paddle2='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_paddle3='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_paddle4='
INFO: unknown config entry: 'joyport0_amiberry_custom_hotkey_touchpad='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_hotkey_leftx='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_hotkey_lefty='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_hotkey_rightx='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_hotkey_righty='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_hotkey_lefttrigger='
INFO: unknown config entry: 'joyport0_amiberry_custom_axis_hotkey_righttrigger='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_a=Right Shift'
INFO: unknown config entry: 'joyport2_amiberry_custom_none_b='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_x='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_y='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_back='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_guide='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_start='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_leftstick='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_rightstick='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_leftshoulder='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_rightshoulder='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_dpup='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_dpdown='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_dpleft=Z'
INFO: unknown config entry: 'joyport2_amiberry_custom_none_dpright=X'
INFO: unknown config entry: 'joyport2_amiberry_custom_none_misc1='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_paddle1='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_paddle2='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_paddle3='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_paddle4='
INFO: unknown config entry: 'joyport2_amiberry_custom_none_touchpad='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_none_leftx='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_none_lefty='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_none_rightx='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_none_righty='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_none_lefttrigger='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_none_righttrigger='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_a=Right Shift'
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_b='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_x='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_y='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_back='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_guide='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_start='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_leftstick='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_rightstick='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_leftshoulder='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_rightshoulder='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_dpup='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_dpdown='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_dpleft=Z'
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_dpright=X'
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_misc1='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_paddle1='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_paddle2='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_paddle3='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_paddle4='
INFO: unknown config entry: 'joyport2_amiberry_custom_hotkey_touchpad='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_hotkey_leftx='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_hotkey_lefty='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_hotkey_rightx='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_hotkey_righty='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_hotkey_lefttrigger='
INFO: unknown config entry: 'joyport2_amiberry_custom_axis_hotkey_righttrigger='
INFO: KS ver = 40 (0x28)
INFO: Stored port 0/1 d=0: added 101 0 SPEEDLINK COMPETITION PRO Game Controller for Android JOY1
INFO: Port0: COMBO 'SPEEDLINK COMPETITION PRO Game Controller for Android' + 'JOY1' matched
INFO: Stored port 1/1 d=0: added 100 0 SPEEDLINK COMPETITION PRO Game Controller for Android JOY0
INFO: Port1: COMBO 'SPEEDLINK COMPETITION PRO Game Controller for Android' + 'JOY0' matched
INFO: Stored port 2/0 d=0: added 102 0 SPEEDLINK COMPETITION PRO Game Controller for Android JOY2
INFO: Port2: COMBO 'SPEEDLINK COMPETITION PRO Game Controller for Android' + 'JOY2' matched
INFO: Port3: NONE

Desktop (please complete the following information):

• OS: Latest Nobara based on Fedora 41

[midwan]

I can't really recreate this here, following your provided steps. I can save and load custom controls for my PS4 controller without any issues.

Can you attach your .uae config file as well, so I can compare it with mine?

[ReofSpa]

Of course. To be sure I created it from scratch with the GUI but same result.
Please find one without (wo_cc) and with (w_cc) custom controls enabled. As one can see my three mappings got in w_cc.
I also tested on Linux Mint (other PC). Same result, so it is not package related.

Nitro(w_cc).uae.txt

Nitro(wo_cc).uae.txt

[midwan]

I'm seeing some very strange entries in your config files, which I don't have in mine (created from scratch just for this test).

Here's mine:
Nitro (1990)(Psygnosis)[cr PDX].uae.txt

There are some expected differences, like the paths and also due to me picking an A500 config, those are fine. But what's curious are the extra lines regarding custom controls. I don't have those in my config, only the lines that are actually mapped differently from the defaults are there, as you can see. And on top of that, you also have a bunch of empty custom control lines at the top of the files (both of them).

Are you sure you created these configs from scratch from the GUI, using the latest version?

[ReofSpa]

Yes, I retested with starting plain amiberry and altering all values. As soon as I add the second joystick (without custom mapping) it adds all these bindings for that one, but not the one in port 1.
I have a remapped joystick (SDL2, button swapping). Could that interfere?

[ReofSpa]

Did another test. I created the configuration file again and compared it line by line. Again all mapping were tried to be saved although not set. I removed all mapping lines from my file, but it still does not work.
The console comes up with

INFO: unknown config entry: 'joyport2_amiberry_custom_none_a=Right Shift'
INFO: unknown config entry: 'joyport2_amiberry_custom_none_dpleft=Z'
INFO: unknown config entry: 'joyport2_amiberry_custom_none_dpright=X'

so this time not complaining about the other lines as these were missing in the uae file (attached).

Test.uae.txt

Now, something made me curious in your file. It looks like your gamepad is located in port 1 (as usual). I recognized that for port 1 no mapping info was stored in the uae file for me. So, I left the mouse in port 0 and did not use the port 2 on the parallel port. And guess what, for port 1 it's working.

Test_port1.uae.txt

No unknown config entry messages in the console and custom controls come up correctly. Could you check whether you have the same behaviour on your side for port 0 or 2?

Sorry, I can't dig deeper into this for some days, because I will be on Easter vacation without access to a suitable test machine.

[midwan]

It seems like you may have found something there, I'll have to test that scenario when I get back (after a few days).
Thanks for providing more details!

[midwan]

Should be fixed with the commit above. Let me know otherwise.