Add CHD-zstd support#1679
Conversation
|
The CI / Docker images need to be adjusted to bundle zstd |
|
Thank you! |
|
Amazing @midwan I will replicate on https://github.com/blitterStudio/amiberry-lite/ once ready here |
|
Thanks for updating your CI stuff. |
|
Looks like |
|
@midwan I looked at CI logs and okay, understood for Apple builds. |
|
I've added a review comment about that, I think it will work (at least, it did on Fedora) if you change the Dependencies file a bit. |
|
@midwan can't locate your comment, but yes, we need a fallback for older CMake actually wich do not bundle FindZstd |
|
Maybe my comments weren't visible, how about now? |
|
it's good, debug stuff was already removed, let me try the find_helper |
|
@midwan looks good now no ? |
|
Merged, thanks! |
|
perfect, let me replicate on https://github.com/blitterStudio/amiberry-lite/ |
Changes proposed in this pull request:
@midwan