Skip to content

Add CHD-zstd support#1679

Merged
midwan merged 2 commits intoBlitterStudio:masterfrom
rtissera:chd-zstd
Jun 17, 2025
Merged

Add CHD-zstd support#1679
midwan merged 2 commits intoBlitterStudio:masterfrom
rtissera:chd-zstd

Conversation

@rtissera
Copy link
Contributor

@rtissera rtissera commented Jun 16, 2025

Changes proposed in this pull request:

  • Adds support for zstd / cdzs compression in CHD format
  • Adjust CMake packaging
  • Fix buffer overflow detected in gdb when using --cdimage option

@midwan

@rtissera rtissera requested a review from midwan as a code owner June 16, 2025 12:54
@rtissera
Copy link
Contributor Author

The CI / Docker images need to be adjusted to bundle zstd

@midwan
Copy link
Collaborator

midwan commented Jun 16, 2025

Thank you!
I'll need to adjust the docker images and the pipelines to test the automated builds. The wiki also needs an update of course.

@rtissera
Copy link
Contributor Author

rtissera commented Jun 16, 2025

Amazing @midwan I will replicate on https://github.com/blitterStudio/amiberry-lite/ once ready here

@rtissera
Copy link
Contributor Author

Thanks for updating your CI stuff.
Removed some lingering debug code, let's see your CI goes on.

@midwan
Copy link
Collaborator

midwan commented Jun 17, 2025

Looks like find_package doesn't work for zstd in some environments, while it works on others.
Fedora and older Debian distros specifically.
The Apple builds should work, I tested them manually. They fail in the PR, because the Apple Certificate the CI is trying to use, is not available on your repo (which is expected).

@rtissera
Copy link
Contributor Author

@midwan I looked at CI logs and okay, understood for Apple builds.
How do we fix the CMake find_package on older distros ?

@midwan
Copy link
Collaborator

midwan commented Jun 17, 2025

I've added a review comment about that, I think it will work (at least, it did on Fedora) if you change the Dependencies file a bit.

@rtissera
Copy link
Contributor Author

@midwan can't locate your comment, but yes, we need a fallback for older CMake actually wich do not bundle FindZstd

@midwan
Copy link
Collaborator

midwan commented Jun 17, 2025

Maybe my comments weren't visible, how about now?

@rtissera
Copy link
Contributor Author

it's good, debug stuff was already removed, let me try the find_helper

@rtissera
Copy link
Contributor Author

@midwan looks good now no ?

@midwan midwan merged commit 81321c7 into BlitterStudio:master Jun 17, 2025
11 of 13 checks passed
@midwan
Copy link
Collaborator

midwan commented Jun 17, 2025

Merged, thanks!

@rtissera
Copy link
Contributor Author

perfect, let me replicate on https://github.com/blitterStudio/amiberry-lite/

@rtissera rtissera deleted the chd-zstd branch June 17, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants