Conversation
# Conflicts: # src/osdep/gui/main_window.cpp
…o imgui # Conflicts: # src/osdep/gui/main_window.cpp
CMake best practices:
- Convert global add_compile_options/add_link_options to target-specific
via AMIBERRY_COMPILE_OPTIONS/AMIBERRY_LINK_OPTIONS variables, preventing
flag leakage into FetchContent third-party builds
- Replace global include_directories/link_directories/link_libraries with
target-specific equivalents on macOS and FreeBSD
- Use ZLIB::ZLIB and CMAKE_DL_LIBS instead of raw library names
- Remove duplicate SDL2 include block and double PNG linking
- Fix -D prefix in target_compile_definitions
- Pin FetchContent deps (mpg123, libserialport-cmake) to commit SHAs
- Rename cmake/{linux,macos}/CMakeLists.txt to install.cmake
- Replace PROJECT_NAME override with AMIBERRY_DISPLAY_NAME + OUTPUT_NAME
- Clean up CMakePresets.json (remove Windows presets, fix descriptions)
CPack packaging:
- Make DEB/RPM dependencies conditional on USE_* feature options
- Fix RPM pre-release versioning (use CPACK_RPM_PACKAGE_RELEASE)
- Add RISC-V architecture mapping for DEB and RPM
- Include pre-release suffix in package version strings
- Use include() instead of add_subdirectory() for packaging scope
Version consolidation:
- Make CMakeLists.txt the single source of truth for version info
- Pass version components as compile definitions (AMIBERRY_VERSION_MAJOR,
AMIBERRY_VERSION_MINOR, AMIBERRY_VERSION_PATCH, AMIBERRY_IS_PRE_RELEASE)
- Auto-generate build date from configure-time timestamp
- Derive UAEMAJOR/UAEMINOR/UAESUBREV, AMIBERRYBETA, AMIBERRYPUBLICBETA,
AMIBERRYDATE, COPYRIGHT, and $VER string from CMake definitions
- Only CMakeLists.txt needs updating for new releases (was 4 files)
Physical CD/DVD drives can now be assigned, besides image files. This applies from both Quickstart (e.g. with the CD32 model) and the HDD panel (Add CDROM dialog).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1740 .