Don't use RPC batching with bitcoind #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shesek
force-pushed
the
202103-no-batching
branch
from
ee8bcfd to
8119cdf
Compare
junderw
pushed a commit
to junderw/electrs
that referenced
this pull request
Dec 12, 2023
…-api Add a POST /txs bulk query-by-txid endpoint
This actually hurts performance because the batched response has to be bueffered, as @TheBlueMatt explains at romanz#373 (comment) Instead, send multiple RPC requests in parallel using a thread pool. Also see romanz#374
shesek
force-pushed
the
202103-no-batching
branch
3 times, most recently
from
03e18a1 to
a9be78d
Compare
shesek
force-pushed
the
202103-no-batching
branch
from
a9be78d to
362515c
Compare
Collaborator
Author
|
This was implemented as part of #89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually hurts performance because the batched response has to be bueffered, as @TheBlueMatt explains in romanz#373 (comment).
Instead, send multiple RPC requests in parallel using a thread pool.
Also see romanz#374.