DesktopStreamer: windows that are streamed independently are activated#101
Merged
jafyvilla merged 1 commit intoBlueBrain:masterfrom Jun 8, 2016
Merged
Conversation
jafyvilla
force-pushed
the
windows_interaction
branch
2 times, most recently
from
dbdf7ab to
8f80339
Compare
Contributor
Author
|
Hold on, I got it wrong for Linux builds |
jafyvilla
force-pushed
the
windows_interaction
branch
2 times, most recently
from
f5820aa to
fd71e42
Compare
Contributor
Author
|
Updated |
| _data.clear(); | ||
| _data.push_back( std::make_tuple( "Desktop", 0, | ||
| getPreviewPixmap( QApplication::primaryScreen()->grabWindow( 0 )))); | ||
| QPixmap preview = |
|
Having this queue of events is a bit annoying but a suppose there was no other way |
Contributor
Author
|
It's the best workaround I could find to the fact that the applications take an iteration of the NSRunLoop to become active after the 'activate' call. Which means that the triggering event gets lost if we don't keep it. I store it in a queue, and it sounds annoying, but in practice this queue won't get too long, as normally all the events are consumed almost immediately. |
apps/DesktopStreamer/MainWindow.cpp
Outdated
| StreamPtr stream( new Stream( *this, index, | ||
| _streamIdLineEdit->text().toStdString(), | ||
| host )); | ||
| host, 0 )); |
Contributor
There was a problem hiding this comment.
make the PID=0 default parameter? This looks awkward in the non-OSX case.
(i.e. sent to the foreground) before applying an interaction event. The mouse cursor is now rendered only on active windows or desktop. Fix crash when hiding (cmd+H) the DesktopStreamer app.
jafyvilla
force-pushed
the
windows_interaction
branch
from
fd71e42 to
afb10bd
Compare
Contributor
Author
|
Done |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(i.e. sent to the foreground) before applying an interaction event.
The mouse cursor is now rendered only on active windows or desktop.
Fix crash when hiding (cmd+H) the DesktopStreamer app.